feat: devex, add Makefile, ruff config, pre-commit hooks, editorconfi…#969
Closed
OutThisLife wants to merge 1 commit into
Closed
feat: devex, add Makefile, ruff config, pre-commit hooks, editorconfi…#969OutThisLife wants to merge 1 commit into
OutThisLife wants to merge 1 commit into
Conversation
9 tasks
Contributor
|
Thanks for putting this together — there are some individually useful ideas here, but we don’t want to take on this repo-wide dev tooling / workflow direction in-tree right now. In particular, we’re not ready to standardize a broad Ruff/pre-commit rollout or expand the contributor workflow surface with a Makefile + non-blocking lint CI layer before the underlying codebase and docs are aligned for that. I appreciate the effort, but I’m going to close this one rather than merge or partially adopt it in its current form. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a standard development toolchain. No source files are changed — the ruff config and pre-commit hooks exist for contributors to opt into locally, and the CI lint job is non-blocking (
continue-on-error: true) until a follow-up formatting PR lands.Related Issue
N/A
Type of Change
Changes Made
Makefile— setup, sync, clean, lint, fmt, check, test, test-fast, test-watch, dev-cli, dev-gatewaypyproject.toml— ruff lint/format config, added ruff + pre-commit + watchfiles to dev deps.pre-commit-config.yaml— ruff + trailing whitespace + merge conflict checks.editorconfig— cross-editor defaults (4-space Python, 2-space YAML, tabs for Makefile).github/workflows/tests.yml— added non-blocking lint job withuvx ruff, added uv cache to test jobHow to Test
make setupcreates venv + installs deps + installs pre-commit hooksmake testruns the full test suitemake lintshows current violations (expected — no formatting pass yet)make fmtauto-fixes lint + format on any files you're working onChecklist
Code
make testand all tests passDocumentation & Housekeeping