fix(cli): honor root-level prefill_messages_file from config.yaml#9655
Closed
flobo3 wants to merge 1 commit into
Closed
fix(cli): honor root-level prefill_messages_file from config.yaml#9655flobo3 wants to merge 1 commit into
flobo3 wants to merge 1 commit into
Conversation
Collaborator
19 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI silently ignores root-level
prefill_messages_filefromconfig.yaml, even though the canonical config schema and gateway/cron loaders use it at the root level.Problem
The config schema (
hermes_cli/config.py:616) definesprefill_messages_fileat the config root. Gateway (gateway/run.py:1084) and cron (cron/scheduler.py:662) both read it from there. But the CLI (cli.py:1740) only checksagent.prefill_messages_file— a root-level key is silently dropped.A user with a valid
config.yamlloses few-shot prefill behavior in the CLI with no error or warning.Fix
Mirror root-level
prefill_messages_fileintoagent.prefill_messages_fileduringload_cli_config(), same fallback pattern already used for root-levelmax_turns(lines 375-382).Only applies when the nested key is not already set, so existing
agent.prefill_messages_fileconfigs are unaffected.Closes #9635