fix(packaging): include qrcode in messaging extra#9504
Closed
anthhub wants to merge 1 commit into
Closed
Conversation
Author
|
Quick review note:
Happy to rebase or tighten the patch further if useful. |
Contributor
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ship
qrcodein themessagingextra so Weixin setup can render terminal QR codes without requiring a follow-up manual install.Related Issue
Fixes #9431
Type of Change
Changes Made
qrcode>=7.0,<8toproject.optional-dependencies.messagingqrcodehermes-agent[messaging]How to Test
. venv/bin/activatepython -m pytest tests/test_project_metadata.py tests/test_packaging_metadata.py -qpip install hermes-agent[messaging]and verify Weixin setup can render a terminal QR code without extra packagesChecklist
Code
pytest tests/ -qand all tests passDocumentation & Housekeeping