Skip to content

fix(packaging): include qrcode in messaging extra#9504

Closed
anthhub wants to merge 1 commit into
NousResearch:mainfrom
anthhub:fix/9431-add-qrcode-messaging-extra
Closed

fix(packaging): include qrcode in messaging extra#9504
anthhub wants to merge 1 commit into
NousResearch:mainfrom
anthhub:fix/9431-add-qrcode-messaging-extra

Conversation

@anthhub

@anthhub anthhub commented Apr 14, 2026

Copy link
Copy Markdown

Summary

Ship qrcode in the messaging extra so Weixin setup can render terminal QR codes without requiring a follow-up manual install.

Related Issue

Fixes #9431

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)

Changes Made

  • Add qrcode>=7.0,<8 to project.optional-dependencies.messaging
  • Add a metadata regression test asserting the messaging extra includes qrcode
  • Update the Weixin docs to reflect that QR rendering ships with hermes-agent[messaging]

How to Test

  1. . venv/bin/activate
  2. python -m pytest tests/test_project_metadata.py tests/test_packaging_metadata.py -q
  3. Install with pip install hermes-agent[messaging] and verify Weixin setup can render a terminal QR code without extra packages

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes
  • I've tested on my platform: macOS

Documentation & Housekeeping

  • I've updated relevant documentation
  • N/A — no config/tool schema updates required

@anthhub

anthhub commented Apr 15, 2026

Copy link
Copy Markdown
Author

Quick review note:

  • isolated single-purpose change
  • regression test included
  • no architecture/workflow changes

Happy to rebase or tighten the patch further if useful.

@teknium1

Copy link
Copy Markdown
Contributor

Merged as part of Batch-5 salvage: #11634

Your commit cherry-picked onto main with authorship preserved. hermes-agent[messaging] now ships with qrcode so Weixin setup can render terminal QR codes out of the box. Closes #9431. Thanks!

Commit SHA on main: 4b1567f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add qrcode to messaging optional dependencies for Weixin setup

2 participants