[codex] fix provider auth compatibility#9444
Closed
g-guthrie wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the submission @g-guthrie. Closing as superseded — the Hermes's Codex auth design was reworked in #12360 ("Hermes owns its own Codex auth; stop touching The valid adjacent fixes from this batch (error parsing, fallback chain on auth failure, reauth UX) landed together in #15104. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore provider/auth compatibility across auxiliary routing and runtime resolution.
Root Cause
A few auth and fallback paths diverged: named custom providers from
providers:lost direct API keys, Codex token resolution leaked across contexts, and auxiliary-provider oauth detection/helpers drifted from current expectations.What Changed
agent/auxiliary_client.pyproviders:runtime resolutionValidation
python -m pytest -o addopts='' tests/agent/test_auxiliary_client.py tests/hermes_cli/test_auth_provider_gate.py tests/hermes_cli/test_opencode_go_in_model_list.py tests/agent/test_credential_pool.py::test_explicit_reset_timestamp_overrides_default_429_ttl -q