Skip to content

fix(cli): wire general plugin commands into main parser#9141

Closed
njiangk wants to merge 1 commit into
NousResearch:mainfrom
njiangk:fix/general-plugin-cli-subcommands
Closed

fix(cli): wire general plugin commands into main parser#9141
njiangk wants to merge 1 commit into
NousResearch:mainfrom
njiangk:fix/general-plugin-cli-subcommands

Conversation

@njiangk

@njiangk njiangk commented Apr 13, 2026

Copy link
Copy Markdown

Summary

  • wire general plugin CLI commands from hermes_cli.plugins into the main argparse tree
  • skip conflicting plugin subcommand names instead of aborting later plugin command registration
  • add CLI integration coverage for general plugin command wiring and conflict handling

Testing

  • source venv/bin/activate && python -m pytest tests/hermes_cli/test_plugin_cli_registration.py -q
  • source venv/bin/activate && python -m pytest tests/hermes_cli/test_chat_skills_flag.py -q
  • source venv/bin/activate && python -m pytest tests/hermes_cli/test_skills_install_flags.py -q
  • source venv/bin/activate && python -m pytest tests/hermes_cli/test_skills_subparser.py -q

Notes

  • full python -m pytest tests/ -q is not green in this environment; it reported many pre-existing failures and sandbox-related log write errors unrelated to this patch

@njiangk njiangk force-pushed the fix/general-plugin-cli-subcommands branch from 959d215 to 2e9b2dc Compare April 14, 2026 00:30
@njiangk njiangk force-pushed the fix/general-plugin-cli-subcommands branch from 2e9b2dc to c354c6e Compare April 14, 2026 01:14
@alt-glitch alt-glitch mentioned this pull request Apr 21, 2026
Closed
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins labels Apr 27, 2026
@alt-glitch

alt-glitch commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Likely duplicate of #13643 — Plugin CLI commands not wired into main argparse tree. Duplicate of #13643 which addresses the same issue. Plugin system issue → P3 per taste rules.

@syahidfrd syahidfrd mentioned this pull request May 1, 2026
Merged
This was referenced May 2, 2026
Closed
Closed
@teknium1

teknium1 commented May 24, 2026

Copy link
Copy Markdown
Contributor

Closing as already fixed on main.

Triage notes (high confidence):
origin/main hermes_cli/main.py:12511-12541 already calls discover_plugins() and iterates get_plugin_manager()._cli_commands to wire general plugin commands into the main parser, with dedup against seen_plugin_commands.

If you still see this on the latest version, please reopen with reproduction steps.

(Bulk-closed during a CLI triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njiangk @alt-glitch @teknium1