fix(config): restore custom provider resolution and nested config han…#8963
Open
devorun wants to merge 1 commit into
Open
fix(config): restore custom provider resolution and nested config han…#8963devorun wants to merge 1 commit into
devorun wants to merge 1 commit into
Conversation
Contributor
|
Related to #4913 / #4914 (also open) — those fix the same user-visible symptom (custom LiteLLM endpoint → 401s) but at a different layer: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dling (#8919)
What does this PR do? Fixes #8919
Custom providers (e.g. LiteLLM on localhost) were ignored and Hermes defaulted to OpenAI endpoints, causing 401 errors.
bug
*_API_KEYkeys (e.g.model.api_key)api_basevsbase_urlschema mismatchHERMES_INFERENCE_PROVIDERandOPENAI_BASE_URLhermes config getlacking nested key traversalFix
_API_KEYinterception to ignore nested keysapi_base → base_urlnormalization inload_configconfig getRestores reliable configuration for custom providers and fixes CLI config behavior.
Related Issue
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs