Skip to content

fix: wire plugin CLI commands to gateway dispatch and CLI handler lookup#8859

Open
zureyewz wants to merge 1 commit into
NousResearch:mainfrom
zureyewz:fix/plugin-cli-commands
Open

fix: wire plugin CLI commands to gateway dispatch and CLI handler lookup#8859
zureyewz wants to merge 1 commit into
NousResearch:mainfrom
zureyewz:fix/plugin-cli-commands

Conversation

@zureyewz

Copy link
Copy Markdown
  • cli.py: _get_plugin_cmd_handler_names() referenced _plugin_commands (non-existent attr) instead of _cli_commands
  • gateway/run.py: add dispatch handler for 'project' canonical command via _handle_project_command (delegates to CLI handler)
  • hermes_cli/commands.py: GATEWAY_KNOWN_COMMANDS now dynamically merges plugin-registered commands from PluginManager._cli_commands at runtime, rather than only snapshotting static COMMAND_REGISTRY at import time. get_gateway_known_commands() used in all dispatch call sites to pick up plugins loaded after gateway startup.

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

@zureyewz zureyewz force-pushed the fix/plugin-cli-commands branch from 852921f to f54a48f Compare April 13, 2026 07:52
- cli.py: _get_plugin_cmd_handler_names() referenced
  _plugin_commands (non-existent attr) instead of _cli_commands
- gateway/run.py: add dispatch handler for 'project' canonical
  command via _handle_project_command (delegates to CLI handler)
- hermes_cli/commands.py: GATEWAY_KNOWN_COMMANDS now dynamically
  merges plugin-registered commands from PluginManager._cli_commands
  at runtime, rather than only snapshotting static COMMAND_REGISTRY
  at import time. get_gateway_known_commands() used in all dispatch
  call sites to pick up plugins loaded after gateway startup.
@zureyewz zureyewz force-pushed the fix/plugin-cli-commands branch from f54a48f to 3395fb8 Compare April 13, 2026 07:58
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins comp/gateway Gateway runner, session dispatch, delivery comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants