Bugfix: preserve routed provider default headers#8784
Open
HiddenPuppy wants to merge 2 commits into
Open
Conversation
439e475 to
a3b0954
Compare
Collaborator
|
Likely duplicate of #8799 — same fix: use public default_headers instead of private _default_headers for routed provider header preservation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_client_kwargsdefault_headersRoot Cause
run_agent.pyinitialized routed OpenAI clients by checking_default_headers, but routed providers such as Kimi expose required headers on the publicdefault_headersattribute. That mismatch dropped the provider's header set before the main client was created, which broke requests that depend on those headers.Validation
source /Users/jerome.xu/Desktop/codex/hermes-agent/.codex-runtime/venv311/bin/activate && pytest -n 0 tests/run_agent/test_run_agent.py::TestRoutedClientDefaultHeaders::test_init_preserves_public_default_headers_from_routed_client tests/run_agent/test_fallback_model.py tests/run_agent/test_primary_runtime_restore.py tests/run_agent/test_context_token_tracking.pyFixes #8779.