feat(telegram): add config option to disable link previews#8728
Closed
kovyrin wants to merge 4 commits into
Closed
feat(telegram): add config option to disable link previews#8728kovyrin wants to merge 4 commits into
kovyrin wants to merge 4 commits into
Conversation
077d6dd to
57a686b
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an opt-in Telegram gateway config option to disable link previews on outbound bot messages.
Problem solved:
Telegram links currently unfurl by default, which makes some Hermes bot replies noisy and visually heavy, especially alert-style messages where the link itself is useful but the preview card is not. This change makes it possible to keep links clickable while suppressing previews when the operator wants cleaner Telegram output.
Why this approach:
cli-config.yaml.exampleRelated Issue
Fixes #
Type of Change
Changes Made
platforms.telegram.extra.disable_link_previewslink_preview_options(is_disabled=True)when availabledisable_web_page_preview=Truefor compatibilitysend_messagepaths ingateway/platforms/telegram.pyTelegramAdapterinstances used in teststests/gateway/test_telegram_approval_buttons.pycli-config.yaml.exampleHow to Test
source .venv/bin/activate python -m pytest tests/gateway/test_telegram_thread_fallback.py tests/gateway/test_telegram_approval_buttons.py -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Targeted test output:
Notes:
pytest tests/ -qstill reports unrelated failures in this checkout on macOS, so the full-suite checkbox is left unchecked.