fix(gateway): wait for systemd restart to become active#8674
Closed
sgaofen wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for this contribution @sgaofen! This fix was superseded before it could be merged. A maintainer landed an equivalent fix to
The approach in this PR and the approach on This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
systemd_restart()from returning immediately after a graceful self-restart request by waiting for the old gateway process to exitsystemctl is-activeuntil the unit transitions away from the old active state and comes back active again, then report a completed restart instead of a fire-and-forget requesttest_gateway_service.pywithout falling back toreload-or-restartFixes #8260.
Testing
python3 -m py_compile /Users/stephenyu/Documents/hermes-agent-wt-8260/hermes_cli/gateway.py /Users/stephenyu/Documents/hermes-agent-wt-8260/tests/hermes_cli/test_gateway_service.pyuv run --directory /Users/stephenyu/Documents/hermes-agent-wt-8260 --extra dev pytest -o addopts='' /Users/stephenyu/Documents/hermes-agent-wt-8260/tests/hermes_cli/test_gateway_service.py -qPlatform Tested
Contribution Guide Notes
CONTRIBUTING.mdand checked for existing open PRs before submitting this scoped bug fix.pytest tests/ -qpass unless explicitly noted.