fix: queue busy gateway messages and preserve auto-reset continuity#8544
Closed
evan966890 wants to merge 1 commit into
Closed
fix: queue busy gateway messages and preserve auto-reset continuity#8544evan966890 wants to merge 1 commit into
evan966890 wants to merge 1 commit into
Conversation
|
I am experiencing exactly this issue. After the daily auto-reset at 4am, the agent completely forgets what we were working on in the previous session. The carryover summary approach would solve this. 👍 |
Contributor
|
Closing as superseded by #14762 — the core busy_input_mode fix is now on main (commit 9d147f7). Your PR also included session.py auto-reset continuity changes that weren't part of this bug's scope; if that's still a live issue for you, please open a separate focused PR and we'll look at it. Thanks for flagging the underlying bug first (Apr 12). |
Collaborator
|
Superseded by #14762 which addressed the same bug and has been merged. |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/stopsemantics fresh by suppressing carryover for manual-stop suspensionsProblem / user-visible failures
This fixes two UX failures in the gateway:
Incoming follow-up messages interrupted active work too aggressively
display.busy_input_mode: queue, but that behavior only applied during restart/stop drain mode, not during ordinary busy turns.Automatic session reset felt like sudden amnesia
What changed
Busy-session behavior
busy_input_modenow governs normal active-session follow-ups, not only restart drain mode.queue, while explicitinterruptconfig/env still restores the old behavior./stop.Auto-reset continuity
reset_context_summarytoSessionEntry.SessionStorebuilds an extractive carryover summary from recent user/assistant transcript turns./stopsuspensions still start truly fresh: no carryover summary is injected formanual_stopsuspensions.Tests
Targeted tests run locally:
python -m pytest tests/gateway/test_restart_drain.py tests/gateway/test_session_reset_notify.py tests/gateway/test_session_race_guard.py tests/gateway/test_session_model_reset.py tests/gateway/test_async_memory_flush.py tests/gateway/test_clean_shutdown_marker.py tests/gateway/test_command_bypass_active_session.py -q -o addopts=''Result:
74 passedNotes
package-lock.jsonmodification./newresets.