Skip to content

Fix DingTalk stream callbacks and session webhooks#8477

Closed
inside-ziwu wants to merge 3 commits into
NousResearch:mainfrom
inside-ziwu:fix/dingtalk-stream-and-webhook
Closed

Fix DingTalk stream callbacks and session webhooks#8477
inside-ziwu wants to merge 3 commits into
NousResearch:mainfrom
inside-ziwu:fix/dingtalk-stream-and-webhook

Conversation

@inside-ziwu

Copy link
Copy Markdown

Summary

  • fix DingTalk stream startup to await the async SDK entrypoint
  • adapt the callback handler to parse SDK CallbackMessage payloads into ChatbotMessage
  • accept official DingTalk session webhook domains and extract text from SDK text/rich text objects

Testing

  • /root/.hermes/hermes-agent/venv/bin/pytest /root/.hermes/hermes-agent/tests/gateway/test_dingtalk.py -q

@teknium1

Copy link
Copy Markdown
Contributor

Closing as superseded by #11471 (#11471) which salvaged @kevinskysunny's minimal fix (#11257) and added a follow-up for the broken _extract_text() path found during E2E testing.

Thanks for the fix — a lot of contributors hit this SDK break at the same time. Your investigation helped confirm the root cause.

@teknium1 teknium1 closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants