Improve checkpoint git error logging#836
Closed
aydnOktay wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR makes the new filesystem checkpoint infrastructure easier to debug in real projects by improving how git errors are logged. The checkpoint manager now logs failing git commands with their exit code, stdout, and stderr, and emits structured logger.error(..., exc_info=True) traces for timeouts, missing git binaries, and unexpected subprocess failures, as well as an explicit error log when the shadow repo cannot be initialized. External behavior and return values are unchanged, but operators now get clear, actionable diagnostics whenever checkpoint creation or restore silently fails, which is critical for trusting the new /rollback feature in production . @teknium1
