feat: support configurable default write directory for skills#8177
Open
uf-hy wants to merge 1 commit into
Open
feat: support configurable default write directory for skills#8177uf-hy wants to merge 1 commit into
uf-hy wants to merge 1 commit into
Conversation
When skills.external_dirs is configured, skill_manage create/edit still writes to ~/.hermes/skills/. This adds a skills.default_write_dir config option so new skills land in the user's preferred directory (e.g. a shared vault or cross-agent skill library). Changes: - Add get_default_write_dir() in skill_utils.py, reading skills.default_write_dir from config.yaml with full validation (path must exist, must differ from local skills dir) - Update _resolve_skill_dir() to use default_write_dir when set - Fix _create_skill() relative path calculation for non-local write dirs - Harden _delete_skill() empty-parent cleanup to only operate within known skill roots Fully backward compatible: when default_write_dir is unset or invalid, behavior is unchanged. Closes NousResearch#4381
This was referenced Apr 22, 2026
|
This setting is so good！Plz merge this ASAP！ Thanks！ |
1 task
|
Is this PR merge still planned? Really useful for custom setups where the self-healing feature is desired and where the skills are maintained in a place that is not the default skills location |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
skills.external_dirsis configured for a shared skill library,skill_manage create/editstill writes to~/.hermes/skills/. This adds askills.default_write_dirconfig option so new skills land in the user's preferred directory.Closes #4381
Changes
agent/skill_utils.pyget_default_write_dir()— readsskills.default_write_dirfromconfig.yaml, validates the path exists and differs from the local skills dirtools/skill_manager_tool.py_resolve_skill_dir()— usesdefault_write_dirwhen set, falls back to~/.hermes/skills/_create_skill()— fixesrelative_to()crash when skill is created outside the local dir_delete_skill()— hardens empty-parent cleanup to only operate within known skill rootsConfig
When
default_write_diris unset or the path does not exist, behavior is identical to before.Testing
All 77 existing skill-related tests pass (
test_skill_manager_tool,test_skill_improvements,test_skill_size_limits).