fix(run_agent): tolerate missing response.created on custom codex streams#8134
Open
ZhangYiqun018 wants to merge 1 commit into
Open
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a custom-endpoint compatibility bug in the Codex Responses streaming path.
Some
provider: custom+api_mode: codex_responsesrelays emit a valid, usable SSE stream but start withresponse.in_progressinstead ofresponse.created.curl -Ncan still read the stream, but the OpenAI SDK's strict Responses stream state machine raises:This PR keeps the strict
responses.stream(...)path as the default, but adds a narrow compatibility fallback for custom providers only:response.createdordering error persists, fall back to Hermes' existingresponses.create(stream=True)parserresponse.in_progressThe behavior for native Codex / non-custom providers stays unchanged.
Related Issue
Fixes #8133
Type of Change
Changes Made
response.createddetection to custom Codex Responses providers inrun_agent.pyresponses.create(stream=True)fallback instead of broadening the main SDK path for every providerresponse.in_progressresponse.createdis missingresponse.in_progressHow to Test
response.createdevent and starts its SSE stream withresponse.in_progress.Expected to have received response.created before response.in_progressand instead completes normally.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Observed failing SDK error before this patch: