fix(gemini): avoid duplicate auth headers on Google AI Studio endpoint#8128
Closed
midcodehub wants to merge 4 commits into
Closed
fix(gemini): avoid duplicate auth headers on Google AI Studio endpoint#8128midcodehub wants to merge 4 commits into
midcodehub wants to merge 4 commits into
Conversation
Contributor
|
Closing in favor of #11961 (merged), which uses @AviArora02-commits' approach from #8530. Thanks for tackling this — the centralized |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix native Gemini authentication against the Google AI Studio OpenAI-compatible endpoint.
Hermes was constructing OpenAI clients in a way that could cause Google to receive multiple auth credentials for Gemini requests, leading to:
This patch introduces a centralized OpenAI compatibility layer for Gemini and routes both primary-agent and auxiliary-client creation through it.
Root cause
Google AI Studio accepts either:
x-goog-api-keyfor standard API keys (AIza...)Authorization: Bearer ...for bearer-style tokensbut not both at the same time.
The fix ensures:
AIza...keys usex-goog-api-keyAQ...continue usingAuthorizationChanges
agent/openai_compat.pyrun_agent.pyagent/auxiliary_client.pytests/agent/test_openai_compat.pyBehavior after fix
AIza...key → sends onlyx-goog-api-keyAQ...) → sends onlyAuthorizationValidation
Ran:
Passed successfully.