security: cache HERMES_YOLO_MODE at import time to prevent subprocess bypass#7994
Open
SHL0MS wants to merge 1 commit into
Open
security: cache HERMES_YOLO_MODE at import time to prevent subprocess bypass#7994SHL0MS wants to merge 1 commit into
SHL0MS wants to merge 1 commit into
Conversation
… bypass HERMES_YOLO_MODE was read via os.getenv() on every approval check. A persistent shell session could export it to bypass approval in subsequent commands. Now cached as _YOLO_AT_STARTUP at module import. Updated 3 tests to monkeypatch the cached constant. Ref NousResearch#4170. Split from NousResearch#4168.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HERMES_YOLO_MODE was read via
os.getenv()on every approval check. A persistent shell session couldexport HERMES_YOLO_MODE=1and bypass approval for all subsequent commands. Now cached as_YOLO_AT_STARTUPat module import time. 9 lines acrosstools/approval.pyand 3 test updates. Ref #4170. Split from #4168.