security: block cloud provider credentials and git credential prompts in subprocesses#7990
Open
SHL0MS wants to merge 1 commit into
Open
security: block cloud provider credentials and git credential prompts in subprocesses#7990SHL0MS wants to merge 1 commit into
SHL0MS wants to merge 1 commit into
Conversation
… prompts in subprocesses Add AWS, Azure, GCP, Kubernetes, Docker, npm, PyPI, SSH agent, and GPG credentials to the subprocess env blocklist. Set GIT_TERMINAL_PROMPT=0 to prevent git from prompting for credentials on clone. Ref NousResearch#4170
1 task
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block cloud provider credentials (AWS, Azure, GCP, Kubernetes, Docker, npm, PyPI, SSH agent, GPG) from leaking to agent subprocesses. Set GIT_TERMINAL_PROMPT=0 to prevent git credential prompts on clone. 24 lines in
tools/environments/local.py. Ref #4170. Split from #4168 for easier review.