fix: replace debug print() with logger.error() in file_tools#780
Merged
Conversation
ImTheDanger-1
approved these changes
Apr 21, 2026
ImTheDanger-1
left a comment
There was a problem hiding this comment.
RLGTM. Clean mcs bump (v1.96.2 → v1.96.3) + METRICS_TARGET removal. No user-facing impact — internal SDK update only. Metrics continue to flow to VictoriaMetrics via OTLP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tools/file_tools.pyiçindekiwrite_file_tool()fonksiyonu hatadurumunda
print()ile doğrudan stdout'a yazıyordu. Bu üretimortamında istenmeyen bir davranış — hatalar logging sistemi üzerinden
yönetilmeli.
Fix
print(f"[FileTools] write_file error: ...")satırı kaldırıldı,yerine
logger.error("write_file error: %s: %s", ...)kullanıldı.loggerzaten dosyanın üstünde tanımlı.Files Changed
tools/file_tools.py