fix(launchd): --force now bootouts existing service before reinstall#7684
Closed
xandersbell wants to merge 1 commit into
Closed
fix(launchd): --force now bootouts existing service before reinstall#7684xandersbell wants to merge 1 commit into
xandersbell wants to merge 1 commit into
Conversation
When running 'hermes gateway install --force' on macOS, the command would fail with exit code 5 if the service was already loaded in launchd, because bootstrap cannot overwrite a running service. The --force flag now calls launchctl bootout before bootstrap, so the service is cleanly unloaded before reinstalling.
Contributor
Author
|
Closing as this has been addressed in a subsequent update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes gateway install --forceon macOS would fail with exit code 5 if the service was already loaded in launchdlaunchctl bootstrapcannot overwrite a running service — must bootout firstFix
When
--forceis passed and a plist already exists, calllaunchctl bootoutbeforebootstrapto cleanly unload the old service.Testing
hermes -p pi gateway install --forceon macOS with a service already running no longer fails