fix: add from __future__ import annotations to 3 remaining files#7611
Open
yes-man-Guo wants to merge 1 commit into
Open
fix: add from __future__ import annotations to 3 remaining files#7611yes-man-Guo wants to merge 1 commit into
yes-man-Guo wants to merge 1 commit into
Conversation
Files using PEP 604 union syntax (X | Y) without the required import: - tools/budget_config.py (int | float) - tools/voice_mode.py (AudioRecorder | TermuxAudioRecorder) - skills/research/polymarket/scripts/polymarket.py (dict | list) 50 other files were already fixed in a previous batch. This catches the remaining 3 that were missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
50 files were previously fixed by adding
from __future__ import annotationsfor PEP 604 union syntax (X | Y) compatibility, but 3 files were missed:tools/budget_config.py— usesint | floattools/voice_mode.py— usesAudioRecorder | TermuxAudioRecorderskills/research/polymarket/scripts/polymarket.py— usesdict | listFix
Added
from __future__ import annotationsto the 3 remaining files, consistent with the previous batch fix.Impact
Without this fix, these files could break on Python versions where PEP 604 union syntax is not supported at runtime without deferred annotation evaluation. Currently works on Python 3.10+ but this ensures broader compatibility and consistency across the codebase.