fix(gateway,cron): activate fallback_model when primary provider auth fails#7432
Closed
Tranquil-Flow wants to merge 1 commit into
Closed
fix(gateway,cron): activate fallback_model when primary provider auth fails#7432Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
… fails When the primary provider raises AuthError (expired OAuth token, revoked API key), the error was re-raised before AIAgent was created, so fallback_model was never consulted. Now both gateway/run.py and cron/scheduler.py catch AuthError specifically and attempt to resolve credentials from the fallback_providers/fallback_model config chain before propagating the error. Closes NousResearch#7230
Contributor
|
Thanks for this fix, @Tranquil-Flow — the change landed on This is an automated hermes-sweeper review. Evidence:
The fix is live on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the primary provider raises
AuthError(expired OAuth token, revoked API key), the error was re-raised beforeAIAgentwas created, sofallback_modelwas never consulted. Now bothgateway/run.pyandcron/scheduler.pycatchAuthErrorspecifically and attempt to resolve credentials from thefallback_providers/fallback_modelconfig chain before propagating the error.Related issue: #7230
Type of Change
Changes Made
gateway/run.py: CatchAuthErrorin_resolve_runtime_agent_kwargs(), try_try_resolve_fallback_provider()before raising.cron/scheduler.py: Same pattern inrun_job()— catchAuthError, iterate fallback chain.How to Test
config.yamlwith a primary provider and afallback_modelChecklist
Closes #7230