fix(cli): sync CLI model/provider from agent after fallback activation#7430
Open
Tranquil-Flow wants to merge 2 commits into
Open
fix(cli): sync CLI model/provider from agent after fallback activation#7430Tranquil-Flow wants to merge 2 commits into
Tranquil-Flow wants to merge 2 commits into
Conversation
86fcb9f to
6b7ce0e
Compare
After run_conversation() returns, the agent's model and provider may have changed due to _try_activate_fallback(). The status bar already reads agent.model, but self.model (used by /model display, session headers, etc.) was never updated. Sync both fields back from the agent after each conversation turn. Closes NousResearch#7385
6b7ce0e to
9ee98c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After
run_conversation()returns, the agent's model and provider may have changed due to_try_activate_fallback(). The status bar already readsagent.model, butself.model(used by/modeldisplay, session headers, etc.) was never updated. This syncs both fields back from the agent after each conversation turn.Related Issue
Closes #7385
Type of Change
Changes Made
cli.py: Afterrun_conversation()completes, syncself.modelandself.providerfromself.agentwhen they differ.How to Test
/modeland session headers show the fallback model.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
N/A — see commit description and PR diff.