You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
surface actionable Slack attachment diagnostics for scope/auth/permission/access failures instead of hiding them behind generic cache/download errors
probe file access with files.info when possible and translate Slack API responses like missing_scope, invalid_auth, and permission-denied variants into user-facing attachment notices
preserve those diagnostics in the message text so the agent can tell the user what to fix, while still logging the detail server-side
update Slack setup docs and interactive config prompts to include files:read
Merged via #16206 — your commit was cherry-picked onto current main with your authorship preserved (67cb62f). Thanks for the thorough diagnostic helpers, especially the mapping from Slack API error codes (missing_scope, invalid_auth, file_not_found, access_denied, etc.) to actionable user-facing text with scope hints and reinstall guidance.
One adjustment: dropped _probe_slack_file_access_issue (the proactive pre-download files.info call). Two reasons — it added one extra Slack API round-trip per attachment even on healthy ones, and it overlapped with the files.info call that PR #11111 added for Slack Connect stubs. The post-failure translation via _describe_slack_download_failure + wiring _describe_slack_api_error into #11111's existing files.info call covers the same user-facing diagnostic surface without the per-message tax. #16206
Superseded by #16206 — salvage of this PR merged with adjustments (dropped proactive files.info probe, kept post-failure diagnostics). Same Slack attachment diagnostic surfacing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/gatewayGateway runner, session dispatch, deliveryP2Medium — degraded but workaround existsplatform/slackSlack app adaptertype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
files.infowhen possible and translate Slack API responses likemissing_scope,invalid_auth, and permission-denied variants into user-facing attachment noticesfiles:readTest Plan
/Users/peteradams/.hermes/hermes-agent/venv/bin/python -m pytest tests/gateway/test_media_download_retry.py tests/gateway/test_slack.py -q -o addopts=''Related
Contributed back from https://github.com/xinbenlv/zn-hermes-agent, which is being used and tested by https://github.com/xinbenlv.