fix(dingtalk): enforce origin validation for session webhooks#7231
Closed
Dusk1e wants to merge 1 commit into
Closed
fix(dingtalk): enforce origin validation for session webhooks#7231Dusk1e wants to merge 1 commit into
Dusk1e wants to merge 1 commit into
Conversation
Contributor
|
Closing — session-webhook origin validation was added to main in commit 37bb4f8 ( Thanks for the security attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented origin validation for
metadata["session_webhook"]inDingTalkAdapter.send()to prevent potential SSRF vulnerabilities.Problem
Previously, the outbound
send()method used the webhook URL from metadata without validation. While inbound requests had origin checks, an attacker could bypass this by providing a malicious webhook URL in the session metadata, potentially reaching internal network services.Changes
gateway/platforms/dingtalk.pyto ensure only official DingTalk domains (e.g.,oapi.dingtalk.com) are targeted.tests/gateway/test_dingtalk.pyto verify:evil.example).Impact
Significantly improves security by closing a metadata-based SSRF vector in the DingTalk gateway adapter.