Skip to content

fix: sync telegram codex model picker with cli discovery#7211

Closed
caodianlong wants to merge 1 commit into
NousResearch:mainfrom
caodianlong:feat/codex-telegram-model-picker-sync
Closed

fix: sync telegram codex model picker with cli discovery#7211
caodianlong wants to merge 1 commit into
NousResearch:mainfrom
caodianlong:feat/codex-telegram-model-picker-sync

Conversation

@caodianlong

Copy link
Copy Markdown

Summary

  • make shared /model provider listings use dynamic OpenAI Codex model discovery
  • keep the previous curated Codex list as a fallback when live discovery fails
  • add regression tests covering dynamic picker results and fallback behavior

Why

Telegram /model was using the static provider list from hermes_cli/models.py, while the CLI hermes model flow already used Codex-specific dynamic discovery via get_codex_model_ids(...). This made Telegram miss newer Codex models like gpt-5.4.

Test Plan

  • python -m pytest tests/hermes_cli/test_model_switch_codex_picker_models.py tests/hermes_cli/test_codex_models.py -q
  • manually verified Telegram /model now shows gpt-5.4 for OpenAI Codex

- use dynamic Codex model discovery in shared /model provider listings
- fall back to curated Codex models if discovery fails
- add regression tests for dynamic list and fallback behavior
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery platform/telegram Telegram bot adapter provider/openai OpenAI / Codex Responses API labels Apr 29, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #17320 — same fix to use live API discovery for openai-codex in gateway/Telegram picker.

@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #17320

@teknium1

Copy link
Copy Markdown
Contributor

Closing as already fixed on main.

Triage notes (high confidence):
origin/main:hermes_cli/model_switch.py:1349-1357 already calls provider_model_ids() for openai-codex which performs live Codex discovery via codex_models.get_codex_model_ids (see origin/main:hermes_cli/models.py:2170-2184). Telegram /model picker shares this code path.

If you still see this on the latest version, please reopen with reproduction steps.

(Bulk-closed during a CLI triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/telegram Telegram bot adapter provider/openai OpenAI / Codex Responses API type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants