fix(config): allow HERMES_HOME permissions override via HERMES_HOME_M…#6994
Closed
devorun wants to merge 1 commit into
Closed
fix(config): allow HERMES_HOME permissions override via HERMES_HOME_M…#6994devorun wants to merge 1 commit into
devorun wants to merge 1 commit into
Conversation
11 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ODE (#6991)
What does this PR do?
Fixes #6991
The Bug
_secure_dir()inconfig.pyunconditionally applies0o700permissions to directories on every gateway startup. This removes the other-execute bit (o+x), preventing web servers (like nginx) from traversing intoHERMES_HOMEsubdirectories to serve content, resulting in persistent 403 Forbidden errors.The Fix
Introduced the
HERMES_HOME_MODEenvironment variable to_secure_dir().0700to maintain strict owner-only access for standard installations.HERMES_HOME_MODE=0701(or similar).is_managed()carve-out for NixOS setups.ValueErrorif an invalid octal string is provided.Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs