Skip to content

fix(streaming): prevent <think> in prose from suppressing response output#6968

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-fe654944
Apr 10, 2026
Merged

fix(streaming): prevent <think> in prose from suppressing response output#6968
teknium1 merged 1 commit into
mainfrom
hermes/hermes-fe654944

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Cherry-picked from PR #6958 by @jquesnelle onto current main.

Fixes a bug where the CLI streaming display treats literal <think> text mentioned in prose (e.g. "not producing <think> tags") as a reasoning block opener, silently swallowing everything after it.

Changes

  1. _stream_delta block-boundary matching (cli.py) — Only enter reasoning suppression when <think> appears at a block boundary (start of stream, after newline, or whitespace-only prefix). Prose mentions pass through as literal text. Adds _flush_stream safety net to recover buffered content from false positives.

  2. _get_anthropic_max_output dot normalization (anthropic_adapter.py) — Normalizes dots to hyphens so anthropic/claude-opus-4.6 matches the claude-opus-4-6 table key. Without this, Sonnet 4.6 gets 128K instead of its correct 64K limit.

  3. Nous Portal max_tokens (run_agent.py) — Extends the existing OpenRouter max_tokens injection to also cover Nous Portal, which proxies to Anthropic's API and requires it.

  4. Reset truncated_tool_call_retries (run_agent.py) — Resets the retry counter after successful tool execution so a single truncation doesn't prevent retries for the rest of the session.

Tests

  • 8 new tests in tests/cli/test_stream_delta_think_tag.py — all pass
  • 401 CLI tests pass (1 pre-existing failure unrelated)
  • 117 anthropic adapter tests pass

…tput

When the model mentions <think> as literal text in its response (e.g.
"(/think not producing <think> tags)"), the streaming display treated it
as a reasoning block opener and suppressed everything after it. The
response box would close with truncated content and no error — the API
response was complete but the display ate it.

Root cause: _stream_delta() matched <think> anywhere in the text stream
regardless of position. Real reasoning blocks always start at the
beginning of a line; mentions in prose appear mid-sentence.

Fix: track line position across streaming deltas with a
_stream_last_was_newline flag. Only enter reasoning suppression when
the tag appears at a block boundary (start of stream, after a newline,
or after only whitespace on the current line). Add a _flush_stream()
safety net that recovers buffered content if no closing tag is found
by end-of-stream.

Also fixes three related issues discovered during investigation:

- anthropic_adapter: _get_anthropic_max_output() now normalizes dots to
  hyphens so 'claude-opus-4.6' matches the 'claude-opus-4-6' table key
  (was returning 32K instead of 128K)

- run_agent: send explicit max_tokens for Claude models on Nous Portal,
  same as OpenRouter — both proxy to Anthropic's API which requires it.
  Without it the backend defaults to a low limit that truncates responses.

- run_agent: reset truncated_tool_call_retries after successful tool
  execution so a single truncation doesn't poison the entire conversation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants