fix(testing): isolate env-sensitive provider and pairing state#6956
Closed
bobashopcashier wants to merge 6 commits into
Closed
fix(testing): isolate env-sensitive provider and pairing state#6956bobashopcashier wants to merge 6 commits into
bobashopcashier wants to merge 6 commits into
Conversation
This was referenced Apr 10, 2026
Contributor
|
Merged via #7654 with authorship preserved. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Separates shared stability fixes into their own focused PR instead of carrying them inside unrelated feature branches:
Related Issue
Related: #6729
Related: #6315
Context: this is extracted from follow-on branch hardening work, not a user-facing feature PR
Type of Change
Changes Made
agent/auxiliary_client.pyto ignore expired Codex pool tokens instead of refreshing through ambient CLI auth during auxiliary credential lookupgateway/pairing.pysoPairingStoreresolves storage under the active Hermes home instead of a stale module-global pathgateway/run.pyto pass the active Hermes home pairing directory intoPairingStore, which fixes pairing/rate-limit state leaking across homes and stabilizes unauthorized-DM behaviorHow to Test
.venv/bin/python -m pytest tests/agent/test_auxiliary_client.py -n0 -k 'ReadCodexAccessToken or ExpiredCodexTokenFallback' -q.venv/bin/python -m pytest tests/tools/test_approval.py tests/tools/test_managed_media_gateways.py tests/gateway/test_approve_deny_commands.py -n0 -q.venv/bin/python -m pytest tests/ -qHERMES_HOMEChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
.venv/bin/python -m pytest tests/agent/test_auxiliary_client.py -n0 -k 'ReadCodexAccessToken or ExpiredCodexTokenFallback' -q→9 passed, 89 deselected.venv/bin/python -m pytest tests/tools/test_approval.py tests/tools/test_managed_media_gateways.py tests/gateway/test_approve_deny_commands.py -n0 -q→127 passed.venv/bin/python -m pytest tests/ -q→9788 passed, 73 skipped, 1 xfailed