fix(gateway): honor explicit HERMES_HOME in systemd install#6941
Closed
bobashopcashier wants to merge 1 commit into
Closed
fix(gateway): honor explicit HERMES_HOME in systemd install#6941bobashopcashier wants to merge 1 commit into
bobashopcashier wants to merge 1 commit into
Conversation
21a7a5b to
8847285
Compare
8847285 to
c19fbb4
Compare
Contributor
|
Closing — the core issue (system service paths not remapped under sudo) was addressed in commit 8dd738c which added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves an explicitly configured
HERMES_HOMEwhen generating Linux systemd gateway units, including the commonsudocase where the current process environment no longer carries the target user's custom Hermes home.Related Issue
Fixes #6729
Related to #5947, but intentionally limited to the systemd gateway install path
Type of Change
Changes Made
hermes_cli/gateway.pyto preserve explicitHERMES_HOMEand probe the target user's login environment before falling back to the existing remap/default logic/root/.hermesand/root/.hermes/profiles/<name>sudo casestests/hermes_cli/test_gateway_service.pyfor explicit env precedence, probed custom/profile homes, and empty-probe fallbackHow to Test
/Users/kennyxie/Documents/Code/clawspace/hermes-agent/.venv/bin/python -m pytest tests/hermes_cli/test_gateway_service.py -qhermes gateway install --systemwith a non-defaultHERMES_HOMEundersudoand confirm the generated unit uses that homeChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
/Users/kennyxie/Documents/Code/clawspace/hermes-agent/.venv/bin/python -m pytest tests/hermes_cli/test_gateway_service.py -q→54 passed