Skip to content

fix(update): allow skipping gateway auto-restart#6740

Closed
ARegalado1 wants to merge 1 commit into
NousResearch:mainfrom
ARegalado1:fix/update-restart-opt-out-6702
Closed

fix(update): allow skipping gateway auto-restart#6740
ARegalado1 wants to merge 1 commit into
NousResearch:mainfrom
ARegalado1:fix/update-restart-opt-out-6702

Conversation

@ARegalado1

Copy link
Copy Markdown
Contributor

Summary

  • add an opt-out for gateway auto-restart during hermes update
  • skip the restart path when HERMES_SKIP_GATEWAY_RESTART is set
  • add regression coverage for the opt-out behavior
  • make the existing systemd restart test explicitly force Linux behavior

Testing

  • uv run pytest tests/hermes_cli/test_update_gateway_restart.py -q

Closes #6702

@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing implementation with #6703 — both add HERMES_SKIP_GATEWAY_RESTART for #6702. Maintainer should pick one.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery labels Apr 29, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing implementation with #6703 — both add HERMES_SKIP_GATEWAY_RESTART for #6702. Maintainer should pick one.

@ARegalado1

Copy link
Copy Markdown
Contributor Author

Closing this ARegalado1 PR to reduce duplicate maintainer burden.

Triage summary:

If maintainers prefer the ARegalado1 version for any reason, the branch can be revived/rebased, but the cleaner default is to let #6703 remain the primary PR for #6702.

@ARegalado1 ARegalado1 closed this May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: hermes update auto-restart kills in-process cron worker with no opt-out

2 participants