fix(codex): recover stale CLI auth sync state#6652
Closed
lkyprogramer wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the submission @lkyprogramer. Closing as superseded — relied on Hermes's Codex auth design was reworked in #12360 ("Hermes owns its own Codex auth; stop touching The valid adjacent fixes from this batch (error parsing, fallback chain on auth failure, reauth UX) landed together in #15104. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a follow-up gap in Codex credential recovery after #5610.
Hermes already knew how to sync an exhausted
openai-codexpool entry from~/.codex/auth.json, but recovery still broke in two common cases:~/.hermes/auth.jsonCodex state, soresolve_codex_runtime_credentials()never pulled in the newer local Codex CLI token pair.last_status=exhaustedruntime state and stayed unavailable.That left gateway / auxiliary Codex flows reporting
no Codex OAuth token foundeven though the local Codex CLI was healthy.This PR makes the recovery path end-to-end:
~/.codex/auth.jsoninto the Hermes auth storeRelated Issue
Fixes #6651
Follow-up to #5610
Type of Change
Changes Made
hermes_cli/auth.py~/.codex/auth.jsoninto the Hermes auth storeresolve_codex_runtime_credentials()so stale / invalid Hermes Codex auth can self-repairagent/credential_pool.pyaccess_token,refresh_token,last_refresh, etc.)agent/auxiliary_client.pyHow to Test
openai-codex~/.codex/auth.jsonrotate to a newer token pair than~/.hermes/auth.jsonno Codex OAuth token foundpytest tests/hermes_cli/test_auth_codex_provider.py tests/agent/test_credential_pool.py tests/agent/test_auxiliary_client.py -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Regression suite used for this patch:
pytest tests/hermes_cli/test_auth_codex_provider.py tests/agent/test_credential_pool.py tests/agent/test_auxiliary_client.py -q # 139 passed🤖 Generated with OpenAI Codex