fix(gateway): make Slack notes aware of scoped Slack tools#6545
Open
daikeren wants to merge 1 commit into
Open
fix(gateway): make Slack notes aware of scoped Slack tools#6545daikeren wants to merge 1 commit into
daikeren wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a prompt/runtime mismatch in the Slack gateway when scoped Slack tools are available.
Today,
gateway/session.pyalways injects a hardcoded Slack platform note saying the agent has no Slack-specific API access and can only read messages sent directly to it. When Slack MCP tools are present, that note becomes stale and can cause false refusals for permalink / thread / history requests.This PR makes the Slack platform note capability-aware while preserving the conservative security model.
Related Issue
Fixes #6533
Type of Change
Changes Made
gateway/session.pygateway/run.pyavailable_tool_namesintobuild_session_context_prompt()tests/gateway/test_session.pycurlaccessHow to Test
Show me the conclusion of this slack thread <slack permalink>Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Focused validation:
Note: I also attempted a broader
tests/gateway/run becausegateway/run.pychanged, but this checkout has unrelated pre-existing failures outside this Slack/session fix, so the claimed validation for this PR is the focused test target above.