fix(hindsight): correct API key env var typo and add Base URL support (#6259)#6274
Closed
devorun wants to merge 2 commits into
Closed
fix(hindsight): correct API key env var typo and add Base URL support (#6259)#6274devorun wants to merge 2 commits into
devorun wants to merge 2 commits into
Conversation
Contributor
|
Merged via PR #6282. Your fix identified the right issues — the camelCase config key mismatch and missing base URL support were both real bugs. The salvage PR corrected the daemon env var naming (upstream hindsight expects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6259
This PR resolves multiple configuration issues in the Hindsight memory plugin for local setups:
HINDSIGHT_LLM_API_KEYto the expectedHINDSIGHT_API_LLM_KEY. Also fixed the internalllmApiKeymismatch tollm_api_key.HINDSIGHT_API_LLM_API_KEYinstead ofHINDSIGHT_API_LLM_KEY.HINDSIGHT_API_LLM_BASE_URLto the setup schema and initialization logic. It defaults tohttps://openrouter.ai/api/v1but allows users to override it viahermes memory setupor their.envfile.README.mdto reflect the correct environment variables.Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs