Skip to content

fix(hindsight): correct API key env var typo and add Base URL support (#6259)#6274

Closed
devorun wants to merge 2 commits into
NousResearch:mainfrom
devorun:patch-36
Closed

fix(hindsight): correct API key env var typo and add Base URL support (#6259)#6274
devorun wants to merge 2 commits into
NousResearch:mainfrom
devorun:patch-36

Conversation

@devorun

@devorun devorun commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #6259

This PR resolves multiple configuration issues in the Hindsight memory plugin for local setups:

  1. Typo Fixes: Corrected the environment variable mapping in the config schema from HINDSIGHT_LLM_API_KEY to the expected HINDSIGHT_API_LLM_KEY. Also fixed the internal llmApiKey mismatch to llm_api_key.
  2. .env Generation: Fixed the duplicate "API" string bug where it was writing HINDSIGHT_API_LLM_API_KEY instead of HINDSIGHT_API_LLM_KEY.
  3. OpenRouter Support: Added HINDSIGHT_API_LLM_BASE_URL to the setup schema and initialization logic. It defaults to https://openrouter.ai/api/v1 but allows users to override it via hermes memory setup or their .env file.
  4. Updated the plugin's README.md to reflect the correct environment variables.

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

@teknium1

teknium1 commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Merged via PR #6282. Your fix identified the right issues — the camelCase config key mismatch and missing base URL support were both real bugs. The salvage PR corrected the daemon env var naming (upstream hindsight expects HINDSIGHT_API_LLM_API_KEY per their .env.example, not HINDSIGHT_API_LLM_KEY), updated the config_changed comparison block, and used an empty default for base URL instead of hardcoding OpenRouter. Thanks for the contribution, @devorun!

@teknium1 teknium1 closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Hermes memory setup for Hindsight

2 participants