fix(discord): honor DISCORD_PROXY for bot client#6184
Closed
trickter wants to merge 1 commit into
Closed
Conversation
1 task
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes the Discord adapter honor
DISCORD_PROXY, with fallback toHTTPS_PROXY/https_proxy, whenconstructing the
discord.pybot client.Why
In proxied environments, Discord gateway connectivity can fail even when other Hermes traffic succeeds. Passing the proxy
explicitly to
commands.Bot(...)makes the Discord adapter consistent with the deployment environment.Change
DISCORD_PROXYHTTPS_PROXY/https_proxycommands.Bot(...)Notes
This is a minimal, targeted change and does not alter other platform adapters or provider routing.