Skip to content

fix: remove named profiles during full uninstall#6137

Closed
iacker wants to merge 4 commits into
NousResearch:mainfrom
iacker:fix/issue-6115-uninstall-profiles
Closed

fix: remove named profiles during full uninstall#6137
iacker wants to merge 4 commits into
NousResearch:mainfrom
iacker:fix/issue-6115-uninstall-profiles

Conversation

@iacker

@iacker iacker commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Résumé

  • corrige hermes uninstall pour supprimer aussi ~/.hermes/profiles/ lors d’une désinstallation complète
  • évite qu’un ancien profil persiste après réinstallation et casse le démarrage
  • ajoute un test de régression couvrant le cas signalé

Vérification

  • source venv/bin/activate && python -m pytest tests/hermes_cli/test_uninstall.py -q
  • source venv/bin/activate && python -m pytest tests/hermes_cli/test_profiles.py -q

Closes #6115

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the contribution @iacker! This fix has since been implemented directly on main — closing as resolved.

Automated hermes-sweeper review.

  • The named-profile uninstall logic (_discover_named_profiles, _uninstall_profile, the interactive prompt) was added to hermes_cli/uninstall.py in commit 79c5a381c (Apr 18 2026), which landed after this PR was opened.
  • That commit covers the same scenario reported in [Bug]: profiles not erased after uninstall, leading to error after reinstall #6115: named profiles surviving a full uninstall and causing errors on reinstall.
  • The current main version of hermes_cli/uninstall.py already contains the _is_default_hermes_home, _discover_named_profiles, and _uninstall_profile helpers, plus the remove_profiles prompt flow — making this PR's changes redundant.

@teknium1 teknium1 closed this Apr 27, 2026
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: profiles not erased after uninstall, leading to error after reinstall

3 participants