fix: mount clipboard images directory into remote sandboxes#6028
Open
Tranquil-Flow wants to merge 2 commits into
Open
fix: mount clipboard images directory into remote sandboxes#6028Tranquil-Flow wants to merge 2 commits into
Tranquil-Flow wants to merge 2 commits into
Conversation
5601679 to
7772948
Compare
7772948 to
766bd79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mounts
~/.hermes/imagesinto remote sandboxes in addition to the existing cache directories. Clipboard screenshots are saved under~/.hermes/images, but remote backends only mirrored cache directories likeimage_cache, which left pasted screenshots invisible inside Docker/remote sandboxes. This PR adds the missing mount + per-file sync coverage so pasted clipboard images become visible to sandboxed runs.Related Issue
Closes #6004
Type of Change
Changes Made
("images", "images")to_CACHE_DIRSintools/credential_files.py/root/.hermes/images~/.hermes/imagesHow to Test
126 passed in 7.58s)Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs