fix: classify builtin skills by bundled directory name#5966
Closed
iacker wants to merge 1 commit into
Closed
Conversation
|
Friendly bump on this PR in case it fell through the cracks \u2014 would love a review when someone has a minute. Thanks! |
Contributor
Author
|
Closing — superseded by #6017 which covers the same builtin skill classification fix with a more complete approach. |
Contributor
Author
|
Closed — superseded/duplicate. See related PR for the canonical fix. |
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
hermes skills listpour reconnaître comme builtin les skills bundled dont le nom de dossier diffère duname:en frontmattervllm/serving-llms-vllmValidation
source venv/bin/activate && python -m pytest tests/hermes_cli/test_skills_hub.py tests/tools/test_skills_sync.py tests/tools/test_skills_tool.py -qCloses #5433