fix(gateway): show full session id and title in /status#5912
Closed
xinbenlv wants to merge 1 commit into
Closed
Conversation
Contributor
|
Merged via PR #5942. Your commit was cherry-picked onto current main with authorship preserved in git log. Thanks for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
/statuscurrently truncates the session id to the first 12 characters, which makes copy/paste and exact session identification annoying. It also omits the session title even when one has already been set.Root Cause
GatewayRunner._handle_status_command()slicessession_entry.session_id[:12]directly and never consults the session database for an existing title.Fix
/status**Title:** ...when a session title existsHow to Verify
/status/title My Session Name, then run/statusagainTest Plan
Targeted test run:
~/.hermes/hermes-agent/venv/bin/python -m pytest tests/gateway/test_status_command.py -q -o addopts=''Risk Assessment
Low — this only changes
/statuspresentation and reads an already-existing title field from the session DB.