Fix Codex stream handling when final response output is empty#5720
Open
misery-hl wants to merge 1 commit into
Open
Fix Codex stream handling when final response output is empty#5720misery-hl wants to merge 1 commit into
misery-hl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hermes can fail on
gpt-5.4/ Codex Responses streams with:Invalid API response: response.output is emptyThis can happen even on very small prompts, and leads Hermes to retry as if the provider returned a malformed or rate-limited response.
Root cause
In
_run_codex_stream(), Hermes already tries several recovery paths:stream.get_final_response()response.output_item.doneHowever, it does not recover the final response object attached to terminal stream events like
response.completed.If the provider/backend returns the usable final payload on
event.response, whileget_final_response()returns an object withoutput=[], Hermes currently treats that as an invalid response and retries.Fix
event.responsefor terminal stream eventsget_final_response()has emptyoutputUser impact
This avoids false malformed/rate-limit retries on
gpt-5.4/ Codex Responses streams and restores expected behavior for affected sessions.Test coverage
Adds a regression test for the case where:
response.completedwith a validresponseget_final_response()returnsoutput=[]