fix(honcho): align honcho_search retrieval with observation direction#5658
Closed
Gabrielgvl wants to merge 1 commit into
Closed
fix(honcho): align honcho_search retrieval with observation direction#5658Gabrielgvl wants to merge 1 commit into
Gabrielgvl wants to merge 1 commit into
Conversation
This was referenced Apr 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
honcho_searchreturning empty results when conclusions are stored in directional observation mode.Root cause: retrieval queried the user peer's self-context, while conclusions are typically written as
assistant -> userin directional mode.Changes
plugins/memory/honcho/session.pytarget_idsupport to_fetch_peer_context(...)target=topeer.context(...)when querying observer->observed contextsearch_context(...)to select retrieval direction by observation mode:_ai_observe_others=True):assistant -> user_ai_observe_others=False): user self-contexttests/honcho_plugin/test_session.pytargetValidation
python -m pytest tests/honcho_plugin/test_session.py -q->34 passedpython -m pytest tests/honcho_plugin -q->124 passedNotes
This keeps read semantics aligned with write semantics from
create_conclusion(...)across observation modes.