fix(gateway): thread-safe PairingStore with atomic writes#5656
Merged
teknium1 merged 1 commit intoApr 6, 2026
Merged
Conversation
4343bd7 to
9a6eff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The gateway runs multiple platform adapters (Telegram, Discord, Slack, etc.)
concurrently in threads sharing a single
PairingStoreinstance. Without locking,concurrent pairing requests raced on the same read-modify-write cycle, which could:
_rate_limits.json_secure_write()also usedpath.write_text()(non-atomic), so a crash mid-writecould leave a truncated JSON file.
Fix
_secure_write()replaced withtempfile.mkstemp+os.fsync+os.replace—readers always see a complete file, never a partial write
PairingStoregainsself._lock(threading.RLock) — all compositeread-modify-write methods (
generate_code,approve_code,revoke,clear_pending) hold it for their full durationTesting
hermes pair listand neither is lost