fix(agent): #5544 strictly enforce toolset filters for memory provide…#5552
Open
MustafaKara7 wants to merge 1 commit into
Open
fix(agent): #5544 strictly enforce toolset filters for memory provide…#5552MustafaKara7 wants to merge 1 commit into
MustafaKara7 wants to merge 1 commit into
Conversation
…mory provider injection
|
Tested this approach on my local setup (RTX 3090, Qwen3-30B-A3B via llama.cpp) and the logic is correct — response time dropped from 42s to ~2s with telegram: []. |
Collaborator
|
Likely duplicate of #5788 — both fix memory tool injection bypassing platform_toolsets/enabled_toolsets config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r injection
What does this PR do?
Fixes #5544
The
MemoryManagerdynamically injectsfact_storetools after the primary tool registry initialization. Previously, this bypassedenabled_toolsetsanddisabled_toolsetsfilters, causing massive token overhead and tool-loops for local models when platforms (e.g. Telegram) explicitly requested zero tools (telegram: []).Added explicit validation against both
self.enabled_toolsetsandself.disabled_toolsetsbefore appending memory schemas toself.tools, ensuring full compliance with user configurations.Fixes #5544