fix(honcho): schema key mismatch breaks self-hosted Honcho config#5184
Closed
Zyphyrs wants to merge 1 commit into
Closed
fix(honcho): schema key mismatch breaks self-hosted Honcho config#5184Zyphyrs wants to merge 1 commit into
Zyphyrs wants to merge 1 commit into
Conversation
…ck to cloud The Honcho plugin's get_config_schema() returned 'base_url' (snake_case) which gets written to ~/.hermes/honcho.json. However, HonchoClientConfig. from_global_config() reads 'baseUrl' (camelCase) from the same file. Result: users who set a custom base URL via 'hermes memory setup' have their URL silently ignored. The client falls back to https://api.honcho.dev, then fails with 'Invalid API key' because the user's API key was set for a self-hosted instance. Fix: align schema key to 'baseUrl' to match the reader. Verified against self-hosted Honcho 3.0.5 at http://localhost:8000
Contributor
|
Thanks @Zyphyrs! The honcho schema key was already corrected to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Honcho memory plugin's
get_config_schema()returns a field with keybase_url(snake_case). This is whathermes memory setupwrites to~/.hermes/honcho.json.However,
HonchoClientConfig.from_global_config()inplugins/memory/honcho/client.pyreadsbaseUrl(camelCase) from that same file:Impact
Users who run
hermes memory setupto configure a self-hosted Honcho instance (e.g.http://localhost:8000) have their base URL silently ignored. The client falls back to the defaulthttps://api.honcho.devcloud endpoint, then fails withInvalid API keybecause the user's API key was set for their self-hosted instance.Symptoms:
hermes honcho statusshowsConnection... OK(because connectivity check passes differently)Peer data unavailable: Invalid API keyappearshttps://api.honcho.devinstead of the configured URLFix
Align the schema key to
baseUrlto match the reader. One-character change.Verification
Tested locally against self-hosted Honcho 3.0.5 at
http://localhost:8000:Before fix (with
base_url):After fix (with
baseUrl):Note
save_config()in the same file has the docstring "Write config to $HERMES_HOME/honcho.json (Honcho SDK native format)". The Honcho Python SDK uses camelCase (baseUrl), so the reader already uses the correct native format. The schema key was the outlier.