fix(agent): sanitize surrogate characters from API responses and before API calls#5074
Closed
ygd58 wants to merge 1 commit into
Closed
fix(agent): sanitize surrogate characters from API responses and before API calls#5074ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
1 task
19 tasks
Contributor
|
Merged via PR #10782. Your surrogate sanitization fix was cherry-picked onto current main with your authorship preserved in git log. Prevents json.dumps crashes from Ollama model output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes surrogate character crashes from Ollama models (Kimi K2.5, GLM-5, Qwen).
Fix — 3 call sites
_sanitize_surrogates() already existed — this wires it to missing call sites.