fix: fall back to LITELLM_KEY for /models metadata auth#4975
Open
bugkill3r wants to merge 1 commit into
Open
Conversation
…#4913) fetch_endpoint_model_metadata() sent unauthenticated /models requests when the caller passed an empty api_key. Fall back to LITELLM_KEY or OPENAI_API_KEY from the environment so custom endpoints that require auth on /models get a proper Authorization header.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_endpoint_model_metadata()sent unauthenticated/modelsrequests whenapi_keywas empty at the call siteLITELLM_KEYorOPENAI_API_KEYfrom the environment, so custom endpoints requiring auth on/modelsget a properAuthorizationheaderTest plan
/modelsrouteLITELLM_KEYin environment