fix: normalize base_url to str before rstrip in anthropic adapter#4968
Closed
bugkill3r wants to merge 1 commit into
Closed
fix: normalize base_url to str before rstrip in anthropic adapter#4968bugkill3r wants to merge 1 commit into
bugkill3r wants to merge 1 commit into
Conversation
…usResearch#4944) When a provider client exposes base_url as an httpx.URL object, calling .rstrip() crashes with AttributeError. Wrap base_url in str() in _is_third_party_anthropic_endpoint and _requires_bearer_auth to handle both str and httpx.URL inputs.
Contributor
|
Superseded by PR #6289 which includes this fix (plus additional thinking block signature stripping for third-party endpoints). Thanks @bugkill3r for the minimal fix approach! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_third_party_anthropic_endpoint()and_requires_bearer_auth()called.rstrip()onbase_urlassuming it's always a stringbase_urlas anhttpx.URLobject (e.g. MiniMax fallback), this crashes withAttributeError: 'URL' object has no attribute 'rstrip'str()handles bothstrandhttpx.URLinputsTest plan
_requires_bearer_auth(httpx.URL("https://api.minimax.io/anthropic"))returnsTruewithout crashing_is_third_party_anthropic_endpoint(httpx.URL("https://example.com"))returnsTruewithout crashing