fix(deps): include Telegram webhook extras in messaging installs#4961
Closed
bg-l2norm wants to merge 1 commit into
Closed
fix(deps): include Telegram webhook extras in messaging installs#4961bg-l2norm wants to merge 1 commit into
bg-l2norm wants to merge 1 commit into
Conversation
Contributor
|
Merged via PR #5288 (consolidated bugfix salvage). Your commit(s) were cherry-picked onto current main with your authorship preserved in git log. Thanks @bg-l2norm for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Docker/all-install Telegram webhook startup failure by including python-telegram-bot webhook extras in messaging dependencies.
Root cause
The Docker image installs Hermes with:
pip install -e ".[all]"[all]includes themessagingextra frompyproject.toml, which previously depended on:python-telegram-bot>=22.6,<23That installs PTB without optional webhook dependencies. When Hermes uses Telegram webhook mode, PTB raises:
RuntimeError: To use start_webhook, PTB must be installed via pip install "python-telegram-bot[webhooks]".Changes
pyproject.tomlmessaging:python-telegram-bot->python-telegram-bot[webhooks](same version range)requirements.txt(convenience file aligned with canonical deps)python-telegram-bot>=20.0->python-telegram-bot[webhooks]>=22.6uv.lockRepro / verification
In an isolated venv:
python-telegram-bot(no extras),Updater.start_webhook(...)raises the exact missing-webhooks RuntimeError.python-telegram-bot[webhooks], that specific RuntimeError is gone.Closes #4915