fix(honcho): port profile isolation fixes to plugin architecture#4642
Closed
erosika wants to merge 1 commit into
Closed
fix(honcho): port profile isolation fixes to plugin architecture#4642erosika wants to merge 1 commit into
erosika wants to merge 1 commit into
Conversation
Port all 6 fixes from NousResearch#4632 to the plugins/memory/honcho/ paths: 1. 3-tier config resolution: profile-local → ~/.hermes/honcho.json → global 2. host=_host_key() in cmd_setup/status/identity from_global_config() calls 3. Bare profile name as aiPeer (not host key with dots) 4. _sanitize_id() on assistant_peer_id 5. add_peers() wrapped in try/except (defense-in-depth) 6. clone_honcho_for_profile gated behind --clone/--clone-all 7. Test fixes for filesystem isolation in resolve_config_path tests
Contributor
Author
|
Closing — base branch is non-main internal branch and changes have been superseded by #9884 (plugin architecture rewrite). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports all profile isolation fixes from #4632 to the
plugins/memory/honcho/paths in #4623.Fixes ported
resolve_config_path()now checks~/.hermes/honcho.json(default profile) between profile-local and global, so non-default profiles find their host blockshost=_host_key()threaded throughfrom_global_config()in setup, status, identity — fixes--target-profilebeing silently ignoreddesign-researchernothermes.design-researcher(dots violate Honcho's ID pattern)_sanitize_id()applied toassistant_peer_id(was raw, user peer and session ID were already sanitized)add_peers()wrapped in try/except as defense-in-depth--clone/--clone-all— bare profile create stays a blank slateresolve_config_pathtests119 honcho plugin tests pass.