fix(agent): append /v1 to custom openai-compatible base URLs (#4600)#4617
Open
devorun wants to merge 1 commit into
Open
fix(agent): append /v1 to custom openai-compatible base URLs (#4600)#4617devorun wants to merge 1 commit into
devorun wants to merge 1 commit into
Conversation
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description
This PR resolves an issue where custom OpenAI-compatible base URLs (e.g.,
https://api.x.ai) were dropping the required/v1path segment duringchat_completionsAPI calls, leading to 404 upstream errors.Fixes #4600
Root Cause
The
AIAgentinitialization explicitly passed the user-providedbase_urldirectly intoclient_kwargs. The underlyingopenaipython client strictly appends the endpoint (likechat/completions) directly to the base URL. If the user didn't manually include/v1at the end of theirOPENAI_BASE_URL, the resulting upstream path became/chat/completionsinstead of/v1/chat/completions, which breaks standard OpenAI-compatible providers (xAI, vLLM, Ollama, etc.).Changes
base_urlright before theopenaiclient is constructed./v1./v1/if it's missing.api_mode == "chat_completions".copilot-acpandopenrouterto prevent side effects.Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs